Make "active-active" a valid production_type value #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosyfrances
approved these changes
May 31, 2024
nikolasrieble
approved these changes
May 31, 2024
| var.production_type == "disk" || | ||
| var.production_type == null | ||
| ) | ||
| condition = contains(["external", "disk", "active-active", null], var.production_type) |
There was a problem hiding this comment.
💭 Would it not be even cleaner if we were to start requiring the operational mode and remove the logic with the node_count influencing the operational mode?
Also, while we are here, please do rename it to operational_mode.
There was a problem hiding this comment.
I'd like to avoid introducing breaking changes with this PR. Renaming it to operational_mode will break all of the existing deployments relying on this module.
Part of the cons of having the module public, and non-versioned 🤷🏼
miguelhrocha
deleted the
TF-15070-make-active-active-a-valid-production-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The
active-activemode used to be identified by thevm_node_countparameter. This breaks possible workflows when someone wants to modify the node_count to a value lower than 2 for maintenance or other reasons.This adds a non-breaking change to decouple the
active-activemode from thevm_node_countparameter.