TF-11115, TF-11117, TF-11116] Adding object store connection string to output #258
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th AA operational mode
| @@ -52,7 +52,7 @@ output "storage_account_container_name" { | |||
| } | |||
|
|
|||
| output "storage_account_primary_blob_connection_string" { | |||
| value = module.object_storage.storage_account_primary_blob_connection_string | |||
| value = local.object_storage.storage_account_primary_blob_connection_string | |||
There was a problem hiding this comment.
💭 Interesting, could you please explain why this change is needed? Does it currently not work?
There was a problem hiding this comment.
following the pattern + to avoid mentioning index in a list.
There was a problem hiding this comment.
We explicitly mention that this repo is a beta, and it is not versioned, but I just want to call out that this would break existing usage of the output, right?
We are fine with it, but really we should just version the repo.
nikolasrieble
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding object store connection string to output
Jira TF-11115
Jira TF-11116
Jira TF-11117