Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-11115, TF-11117, TF-11116] Adding object store connection string to output #258

Merged
merged 2 commits into from
Dec 10, 2024
+1 −1
Merged

TF-11115, TF-11117, TF-11116] Adding object store connection string to output #258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efc4703
TF-11115, TF-11117, TF-11116] tfectl support bundle on k8s cluster wi…
kkavish Dec 10, 2024
8cf098c
Merge branch 'main' into kkavish/object-store-integration
kkavish Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ output "storage_account_container_name" {
}

output "storage_account_primary_blob_connection_string" {
value = module.object_storage.storage_account_primary_blob_connection_string
value = local.object_storage.storage_account_primary_blob_connection_string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Interesting, could you please explain why this change is needed? Does it currently not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following the pattern + to avoid mentioning index in a list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We explicitly mention that this repo is a beta, and it is not versioned, but I just want to call out that this would break existing usage of the output, right?

We are fine with it, but really we should just version the repo.

description = "The connection string associated with the primary location for the storage account used by TFE"
}

Expand Down
Loading