-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] provider/openstack - Add support for identity v3 #7041
[WIP] provider/openstack - Add support for identity v3 #7041
Conversation
Add: - default_domain in case the domain scope and user domain are the same - user_domain_name and user_domain_id identifying the domain where the user lives - project_domain_name and project_domain_id for project scoping - project_name and project_id which is the new naming for tenant since OpenStack cli 1.7.0
@sbourlon Cool! Thank you for this. I've subscribed to rackspace/gophercloud#593 and will also keep an eye on it. As an aside, I'm awaiting rackspace/gophercloud#528 which will help with #6458. |
Thanks @jtopjian! The repo https://github.com/rackspace/gophercloud is moving to a new one https://github.com/gophercloud/gophercloud. I will have to test and move the gophercloud PR to this new repo. |
👍 I followed along the conversation today. The move go gophercloud/gophercloud was news to me, too. The Terraform OpenStack provider in general will have to move over to it... one step at a time, I guess 😄 |
If needed, I uploaded the build of this PR to the latest release of my cluster tool: https://github.com/hpcloud/stackato-cluster-tool/releases/tag/v0.9.0 |
Looking forward to seeing this PR go through :) |
@dpmex4527 Me too! However, we would need to have Terraform using the new gophercloud (rackspace/gophercloud#592), then I will migrate rackspace/gophercloud#593 to it. |
@sbourlon would you happen to have a gist or some instructions on how to build this PR for me to test? Would like to validate as we currently use Openstack V3 at work and would love to help test it out. |
@sbourlon nvm just saw in message thread link to the build with V3 supported :) Thanks! |
@sbourlon looks like the new gophercloud repo is up and receiving PR's now (I see a few PR's and issues out there now). Hoping we can see V3 support in terraform soon :) Also, someone already submitted a V3 related PR. Similar to yours? gophercloud/gophercloud/pull/13 |
Just a heads up: The Terraform OpenStack provider won't immediately be switching to the new I'm in the process of reviewing the code now, basically going through each acceptance test as a way of identifying breaking changes. I'm pretty sure any public-facing changes will just be a few call rewrites, but will take some time to confirm. I do intend to switch over as soon as possible, though. :) |
@jtopjian What's the latest on this change and the switch to gophercloud/gophercloud? As I've just hit the same issue I believe where I can't scope Terraform auth to a specific project name :( |
@jtopjian Cool, cheers... I'll have a look... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I just sent a PR to the gophercloud repository in order to improve the identity v3 support: rackspace/gophercloud#593. While waiting for them to merge it, here is the code on the Terraform side. I am actually already using it for my Stackato Cloud Foundry cluster deployment automation tool (https://github.com/hpcloud/stackato-cluster-tool).
This PR adds the following keys:
Before merging this PR, we would need to bump the Godeps gophercloud dependency after they merge rackspace/gophercloud#593.
Please, let me know if I am missing something or if this PR needs to be improved.