-
Notifications
You must be signed in to change notification settings - Fork 185
Conversation
to improve the readability and use a if/else if/else flow.
…main to support project and domain scoping, user domain authentication and default domain.
Thank you for the PR, but this repo is currently in feature-freeze mode. See #592 |
Thanks @jrperritt for the update. Would it still be possible to merge the PR after the feature-freeze mode is done? |
In this repo, no. In |
Thanks. I will test the PR against the new repo and sent a new PR to gophercloud/gophercloud. |
Closing this. Hopefully we'll see it in the new repo |
@sbourlon / @jrperritt Any joy with making these changes against gophercloud/gophercloud? |
@sbourlon @fatmcgav While reviewing hashicorp/terraform#7041, I spent the past few evenings looking over the current gophercloud/gophercloud v3 implementation and I think everything is already in place. I even went as far as re-implementing the scoping portion of this PR and saw that the end result was the same. While there is no direct support for However, I could be wrong. If so, can someone please provide an example of where scoping still needs work in the new Gophercloud repository? |
@jtopjian I'm inclined to agree, as I've been running TF using the latest code and using domain and project scoping quite happily. Cheers |
OpenStack identity v3 instroduced domains which I added in this PR
Please, let me know if I am missing something or if this PR needs to be improved.