Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared): support different loading options for workspace via hawtconfig.json #646

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

tadayosi
Copy link
Member

@tadayosi tadayosi commented Nov 2, 2023

Fix #421

With this fix, now hawtconfig.json is enhanced to accept jmx option with workspace in it like this:

{
  ...
  "jmx": {
    "workspace": ["hawtio", "java.lang/type=Memory", "org.apache.camel", "no.such.domain"]
  },
  ...
}

The workspace accepts either boolean or string[] and if it's set to false you can disable the workspace completely, which is effectively the zero preload mode requested at #421.

Copy link

github-actions bot commented Nov 2, 2023

Test Results

    8 files  ±0      8 suites  ±0   50m 1s ⏱️ - 5m 55s
  59 tests ±0    58 ✔️ ±0  1 💤 ±0  0 ±0 
468 runs  ±0  460 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit 59b8a4e. ± Comparison against base commit 862206b.

@hawtio-ci
Copy link

hawtio-ci bot commented Nov 2, 2023

Test results

Run attempt: 722
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-node(18)-java(11)-firefox 59 58 1 0 0 306.012
results-quarkus-node(18)-java(17)-firefox 59 58 1 0 0 417.007
results-quarkus-node(20)-java(11)-firefox 59 58 1 0 0 441.363
results-quarkus-node(20)-java(17)-firefox 59 58 1 0 0 301.188
results-springboot-node(18)-java(11)-firefox 58 57 1 0 0 437.609
results-springboot-node(18)-java(17)-firefox 58 57 1 0 0 425.451
results-springboot-node(20)-java(11)-firefox 58 57 1 0 0 370.461
results-springboot-node(20)-java(17)-firefox 58 57 1 0 0 302.539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect - Consider providing zero preload mode for JMX tree/workspace
1 participant