Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Added infra profile param for d435 #49

Merged
merged 1 commit into from
May 23, 2024

Conversation

hello-amal
Copy link
Collaborator

Description

When realsense_ros disaggregated profiles (here), the D435i's depth_module.profile got split into depth_module.depth_profile and depth_module.infra_profile. #41 fixed the former, but not the latter, which broke the "Depth Sensing" feature. This PR fixes that.

Before screenshot:
Screenshot 2024-05-23 at 2 15 10 PM

After screenshot:
Screenshot 2024-05-23 at 2 13 37 PM

Testing

  • Recreate the issue: On the current master branch, launch the web interface, add a "Realsense" camera view with the display buttons enabled, check "depth sensing," and verify that it shows very few if any points.
  • Verify the fix: On this PR's branch, launch the web interface, add a "Realsense" camera view with the display buttons enabled, check "depth sensing," and verify that it shows points as expected.

Copy link
Contributor

@hello-fazil hello-fazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Looks good to merge.

@hello-amal hello-amal merged commit 3eb8bcf into master May 23, 2024
@hello-amal hello-amal deleted the amaln/bugfix_depth_sensing branch May 23, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants