fix(cli): guard PowerShell process queries against exited PIDs - #3571
Merged
Conversation
Get-CimInstance returns null when the target process has already exited. Calling .CreationDate or .ParentProcessId on null throws InvokeMethodOnNull, which writes to stderr even though the try/catch handles it. On Windows CI this stderr noise pollutes the test runner's output and can cause spurious exit code 1. Two fixes: - Null-check the CimInstance before accessing properties - ErrorAction SilentlyContinue + stdio stderr suppression Fixes CI 'Tests on windows-latest' flake on main.
miguel-heygen
approved these changes
Aug 31, 2026
Collaborator
Merge activity
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processIdentityandprocessParentPidcallGet-CimInstance Win32_Processto look up process metadata on Windows. When the target process has already exited,Get-CimInstancereturns null and calling.CreationDate.ToFileTimeUtc()or.ParentProcessIdon it throwsInvokeMethodOnNull. The try/catch handles it, but PowerShell writes the error to stderr, which pollutes the test runner's output and causes spurious exit code 1 on Windows CI.Two fixes per call site:
$p = ...; if ($p) { $p.Property })-ErrorAction SilentlyContinue+stdio: ["pipe", "pipe", "ignore"]to suppress any residual stderrFixes the recurring
Tests on windows-latestflake on main.Test plan
— Miga