Skip to content

fix(cli): guard PowerShell process queries against exited PIDs #3571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miguel-heygen merged 2 commits into from
Aug 31, 2026
Merged

fix(cli): guard PowerShell process queries against exited PIDs #3571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3051b68
fix(studio): re-apply WebMCP test polyfill fix (#3532 regression)
miga-heygen Aug 31, 2026
03c01f7
fix(cli): guard PowerShell process queries against exited PIDs
miga-heygen Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/cli/src/utils/orphanCleanup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ export function processIdentity(pid: number): string | null {
"-NoProfile",
"-NonInteractive",
"-Command",
`(Get-CimInstance Win32_Process -Filter 'ProcessId = ${pid}').CreationDate.ToFileTimeUtc()`,
`$p = Get-CimInstance Win32_Process -Filter 'ProcessId = ${pid}' -ErrorAction SilentlyContinue; if ($p) { $p.CreationDate.ToFileTimeUtc() }`,
],
{ encoding: "utf8", timeout: 2000 },
{ encoding: "utf8", timeout: 2000, stdio: ["pipe", "pipe", "ignore"] },
).trim();
return created ? `windows:${created}` : null;
}
Expand Down Expand Up @@ -140,9 +140,9 @@ function processParentPid(pid: number): number | null {
"-NoProfile",
"-NonInteractive",
"-Command",
`(Get-CimInstance Win32_Process -Filter 'ProcessId = ${pid}').ParentProcessId`,
`$p = Get-CimInstance Win32_Process -Filter 'ProcessId = ${pid}' -ErrorAction SilentlyContinue; if ($p) { $p.ParentProcessId }`,
],
{ encoding: "utf8", timeout: 2000 },
{ encoding: "utf8", timeout: 2000, stdio: ["pipe", "pipe", "ignore"] },
)
: execFileSync("ps", ["-o", "ppid=", "-p", String(pid)], {
encoding: "utf8",
Expand Down
8 changes: 4 additions & 4 deletions packages/studio/src/webmcp/useStudioAgentTools.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,16 @@ describe("useStudioAgentTools", () => {
expect(signal?.aborted).toBe(true);
});

it("registers nothing when the browser has no WebMCP", async () => {
it("boots cleanly when the browser has no native WebMCP", async () => {
removeModelContext();

await act(async () => {
mountTools(deps({ getSnapshot: () => snapshot() }));
});

// The assertion is that mounting did not throw; a browser without the API
// must still boot Studio.
expect(document).not.toHaveProperty("modelContext");
// The assertion is that mounting did not throw; a browser without the
// native API must still boot Studio. The polyfill may install
// document.modelContext as a fallback — that is expected.
});

it("registers nothing when the preference is turned off", async () => {
Expand Down
Loading