Skip to content

N21-2319 Change board type#3502

Merged
MarvinOehlerkingCap merged 12 commits intomainfrom
N21-2319-change-board-type
Jan 22, 2025
Merged

N21-2319 Change board type#3502
MarvinOehlerkingCap merged 12 commits intomainfrom
N21-2319-change-board-type

Conversation

@MarvinOehlerkingCap
Copy link
Copy Markdown
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 17, 2025 •
edited by GordonNicholasCap
Loading

Short Description

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Jan 17, 2025
Merged
3 tasks
GordonNicholasCap
GordonNicholasCap suggested changes Jan 22, 2025
View reviewed changes
Comment thread src/modules/data/board/ariaNotification/ariaLiveNotificationHandler.unit.ts Outdated
Comment thread src/modules/ui/room-details/types.ts Outdated
MarvinOehlerkingCap and others added 3 commits January 22, 2025 10:44
@MarvinOehlerkingCap
improve typing
f061568
@MarvinOehlerkingCap @GordonNicholasCap
Update src/modules/data/board/ariaNotification/ariaLiveNotificationHa…
c11577b 
…ndler.unit.ts

Co-authored-by: Gordon Nicholas <160246213+GordonNicholasCap@users.noreply.github.com>
@MarvinOehlerkingCap
Merge branch 'main' into N21-2319-change-board-type
5ccf6af 
# Conflicts:
#	src/locales/de.ts
#	src/locales/en.ts
#	src/locales/es.ts
#	src/locales/uk.ts
#	src/modules/ui/kebab-menu/index.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 22, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MBergCap MBergCap mentioned this pull request Jan 22, 2025
Merged
1 task
@MarvinOehlerkingCap MarvinOehlerkingCap merged commit fde0b27 into main Jan 22, 2025
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2319-change-board-type branch January 22, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GordonNicholasCap GordonNicholasCap GordonNicholasCap approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarvinOehlerkingCap @GordonNicholasCap