Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-2319 Change board type #5442

Merged
merged 7 commits into from
Jan 22, 2025
Merged

N21-2319 Change board type #5442

merged 7 commits into from
Jan 22, 2025

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Jan 17, 2025 •
edited by GordonNicholasCap
Loading

Description

Links to Tickets or other pull requests

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@MarvinOehlerkingCap MarvinOehlerkingCap mentioned this pull request Jan 17, 2025
Merged
3 tasks
sdinkov
sdinkov requested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sdinkov sdinkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all @src import as there was a change removing this path from tsconfig here BC-8479 - Remove @src

@MBergCap MBergCap mentioned this pull request Jan 22, 2025
Merged
1 task
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit a580ad0 into main Jan 22, 2025
76 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-2319-change-board-type branch January 22, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdinkov sdinkov sdinkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarvinOehlerkingCap @sdinkov