-
Notifications
You must be signed in to change notification settings - Fork 166
Rename __HostHttp- to __Host-Http- for improved backwards compat #3153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(build failure seems unrelated) |
|
Filed #3155 on the build failure. This seems okay to me, but we'll need test coverage changes and a corresponding change to the Cookie Store API. And ideally they're all linked from OP for clarity. |
on it |
|
No concerns on the name from me. |
|
I don't think a name change is editorial. This has normative impact. |
As discussed at https://groups.google.com/a/chromium.org/g/blink-dev/c/WsXlDO6oO2E/m/ApG8wQCkAQAJ, this renames the __HostHttp- cookie prefix to make it easier to deploy before support for it becomes ubiquitous. That way, developers can rename their cookies from `__Host-something` to `__Host-Http-something` without losing their host-scope semantics. Spec PRs: httpwg/http-extensions#3153 and whatwg/cookiestore#286 Change-Id: Ibef7870914618e54d16b3ff16ccb8946db32bb76 Bug: 437940200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6839519 Reviewed-by: Dylan Cutler <[email protected]> Commit-Queue: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1501411}
Which channel? Could you summarize here? |
|
The #cookies channel. Discussion
|
Following discussions on Matrix, this renames the
__HostHttp-to be__Host-Http-.While a bit uglier, this makes it easier to deploy this to non-supporting browsers while not losing the characteristics that
__Host-provides.Tested in web-platform-tests/wpt#54226 and web-platform-tests/wpt#54260. Relevant cookie store changes in whatwg/cookiestore#286