no-vary: updating CACHING (fixes #3285) #3286
Conversation
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Hmm, I think turning the bulleted list into a sentence with significant mental nesting and a somewhat ambiguous verb subject is a downgrade in clarity. Could we just include the replaced text, and make any changes necessary to fit it in?
|
Hm. I think the "significant mental nesting" happens when you replace a single list item by a new list. In particular, the two cases in the list can be trivially collapsed into a single rule, right? But yes, editorial. |
|
|
||
| is replaced with: | ||
|
|
||
| > the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match or are equivalent modulo search variance, and |
There was a problem hiding this comment.
I feel like preserving the structure of the original text in HTTP-CACHING is more clear than saying it's replaced with "one of the following" and sub-bullets.
If we think it's valuable, we could still include the references to the other sections:
| > the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match or are equivalent modulo search variance, and | |
| > the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match, or are equivalent modulo search variance ({{comparing}}), given the variance obtained ({{obtain-a-url-search-variance}}) from the stored response, and |
There was a problem hiding this comment.
@reschke Friendly ping, what do you think about the suggestion?
There was a problem hiding this comment.
I still prefer "my suggestion, but at the end of the day, it's mostly an editorial choice.
Maybe ask @mnot ?
|
Thought: maybe had the complete updated algorithm in an appendix? |
|
I don't feel super strongly about the additional references, let's merge the PR as-is. Thanks! |
No description provided.