Skip to content

no-vary: updating CACHING (fixes #3285) #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nidhijaju merged 1 commit into from
Jan 8, 2026
Merged

no-vary: updating CACHING (fixes #3285) #3286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions draft-ietf-httpbis-no-vary-search.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,15 @@ So, for example, given any non-default value for `No-Vary-Search`, such as `No-V

# Caching {#caching}

If a cache {{HTTP-CACHING}} implements this specification, the presented target URI requirement in {{Section 4 of HTTP-CACHING}} is replaced with:
If a cache {{HTTP-CACHING}} implements this specification, the presented target URI requirement in {{Section 4 of HTTP-CACHING}}:

* one of the following:
* the presented target URI ({{Section 7.1 of HTTP}}) and that of the stored response match, or
* the presented target URI and that of the stored response are equivalent modulo search variance ({{comparing}}), given the variance obtained ({{obtain-a-url-search-variance}}) from the stored response.
> the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match, and
{:quote}

is replaced with:

> the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match or are equivalent modulo search variance, and
Copy link
Contributor

@nidhijaju nidhijaju Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like preserving the structure of the original text in HTTP-CACHING is more clear than saying it's replaced with "one of the following" and sub-bullets.

If we think it's valuable, we could still include the references to the other sections:

Suggested change
> the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match or are equivalent modulo search variance, and
> the presented target URI (Section 7.1 of [HTTP]) and that of the stored response match, or are equivalent modulo search variance ({{comparing}}), given the variance obtained ({{obtain-a-url-search-variance}}) from the stored response, and

Copy link
Contributor

@nidhijaju nidhijaju Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reschke Friendly ping, what do you think about the suggestion?

Copy link
Contributor Author

@reschke reschke Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still prefer "my suggestion, but at the end of the day, it's mostly an editorial choice.

Maybe ask @mnot ?

Copy link
Member

@mnot mnot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong feelings here.

{:quote}

Cache implementations MAY fail to reuse a stored response whose target URI matches _only_ modulo URL search variance, if the cache has more recently stored a response which:

Expand Down