Skip to content

Commit

Permalink
Add rdfs:label to provisional terms
Browse files Browse the repository at this point in the history
This change allows the rdfs:label to be provided upfront, rather than being added during the enrichment process where labels come from a reference ontology.

If a concept is already known, enriching it by its identifier by its source ontology gives us all its details, including the official name. But for temporary or provisional concepts, we use  ccf_pref_label to store its given name, and the official label is not assigned yet. This update changes that by allowing users to add the label directly in the normalized form.
  • Loading branch information
johardi committed Oct 10, 2024
1 parent 3806cbd commit c2600b0
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
11 changes: 10 additions & 1 deletion schemas/src/digital-objects/asct-b.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ default_range: string

imports:
- linkml:types
- ../shared/entity-base
- ../shared/metadata-base

settings:
Expand All @@ -37,6 +36,7 @@ classes:
abstract: true
slots:
- id
- label
- conforms_to
- parent_class
- ccf_pref_label
Expand Down Expand Up @@ -257,6 +257,15 @@ slots:
required: false
range: CharacterizingMarkerSet
multivalued: true
id:
required: true
range: uriorcurie
identifier: true
label:
required: false
slot_uri: rdfs:label
annotations:
owl: AnnotationProperty, AnnotationAssertion
ccf_pref_label:
required: true
slot_uri: ccf:ccf_pref_label
Expand Down
3 changes: 3 additions & 0 deletions src/normalization/normalize-asct-b.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ function normalizeAs(collector, { id: as_id, name: as_name, is_provisional }, in
};
if (is_provisional) {
obj['parent_class'] = 'ccf:AnatomicalStructure';
obj['label'] = as_name.trim();
}
collector.push(obj);
}
Expand Down Expand Up @@ -188,6 +189,7 @@ function normalizeCt(collector, { id: ct_id, name: ct_name, is_provisional }, in
};
if (is_provisional) {
obj['parent_class'] = 'ccf:CellType';
obj['label'] = ct_name.trim();
}
collector.push(obj);
}
Expand Down Expand Up @@ -255,6 +257,7 @@ function normalizeBm(collector, { id: bm_id, name: bm_name, b_type, is_provision
};
if (is_provisional) {
obj['parent_class'] = 'ccf:Biomarker';
obj['label'] = bm_name.trim();
}
collector.push(obj);
}
Expand Down

0 comments on commit c2600b0

Please sign in to comment.