Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update metadata, histogram, visualization, violin plot modules component #772

Draft
wants to merge 10 commits into
base: cde-mvp2
Choose a base branch
from

Conversation

bhushankhope
Copy link
Contributor

@bhushankhope bhushankhope commented Oct 7, 2024

Updated the metadata & histogram component on the cde vis page according to current spec

Copy link

nx-cloud bot commented Oct 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c7eef8a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --target=test --parallel=3 --exclude=tag:karma-test-runner --ci --code-coverage
✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Copy link

github-actions bot commented Oct 7, 2024

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

Copy link
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Bhushan! Thanks so much for the quick work on this: I love the smoothness of the interactions for showing/hiding the unknown metadata and expanding/collapsing the metadata panel.

A couple of questions:

  • Is it possible to implement the icon button micro tooltips for expand/collapse + more?
  • Is it possible to use the basic text button for the top two metadata entries in the sample visualizations?

Looking so good! Thanks for all!

@bhushankhope bhushankhope changed the title update metadata module update metadata and histogram component Oct 8, 2024
@LibbyUX LibbyUX self-requested a review October 9, 2024 13:26
Copy link
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love those tooltips! Thanks for getting those squared away. They look/feel perfect!

Is it possible to get a hover state on the basic text button in the metadata panel? This is what I see when I hover on the prototype vs the preview:

Prototype

E20C872F-E816-4225-8DDB-CB73FFE3E347

Preview

405A6001-5EB2-4C2A-A05E-8753AB431DDA

@bhushankhope bhushankhope changed the title update metadata and histogram component update metadata, histogram, visualization, violin plot modules component Oct 10, 2024
@bhushankhope bhushankhope marked this pull request as draft October 16, 2024 14:40
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants