Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cde design system #773

Open
wants to merge 8 commits into
base: cde-mvp2
Choose a base branch
from
Open

Cde design system #773

wants to merge 8 commits into from

Conversation

edlu77
Copy link
Contributor

@edlu77 edlu77 commented Oct 8, 2024

Added design system and updated styles for landing page, create vis page, and visualization page

Contains updates to create vis page from #735

@edlu77 edlu77 self-assigned this Oct 8, 2024
Copy link

nx-cloud bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

Copy link
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edlu77, thank you so much for getting this started! It's looking good!

Some requests for this preview:

  • I'm looking for updates in our design system to build this nav header:
    • I created a list of design system updates for all nav headers on this issue to help organize what is needed in the design system first before implementing in the CDE: Use design system nav header #767
  • Is it possible to get this to stick at the top of the page on scroll? This is functionality needed for all nav headers in the design system.
  • I would like to see the updated HuBMAP apps sidenav implemented as well on click of the Apps icon button.

Thank you so much! Please don't hesitate to reach out if you have questions!

image

Copy link

sonarcloud bot commented Oct 16, 2024

@edlu77
Copy link
Contributor Author

edlu77 commented Oct 16, 2024

@LibbyUX I've made the header updates in a separate PR: #778

Please comment there with any feedback. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants