Segmentation mask file size validator #62
Conversation
…res it with its parent base image.
| if not data_path.is_absolute(): | ||
| data_path = Path(self.paths[0]).parent / data_path | ||
|
|
||
| for glob_expr in [ |
There was a problem hiding this comment.
Maybe consolidate this list into a class attribute or something unless there's a chance we'd want to have different patterns for mask/base images.
There was a problem hiding this comment.
I've refactored this a bit, how does it look now?
src/ingest_validation_tests/segmentation_mask_imagesize_validation.py
Outdated
Show resolved
Hide resolved
| for file in Path( | ||
| GetParentData( | ||
| row["parent_dataset_id"], self.globus_token, self.app_context | ||
| ).get_path() | ||
| ).glob(glob_expr): | ||
| parent_filenames_to_test.append(file) | ||
|
|
||
| assert len(filenames_to_test) != 1, "Too many or too few files Mask" |
There was a problem hiding this comment.
Reading this again, I'm actually not sure how many files we are expecting--more than 1? I think I misread this as == 1 before, which I thought made sense.
Would it be reasonable instead to do something like assert len(filenames_to_test) == len(parent_filenames_to_test), "Mismatched number of files in dataset and parent_dataset directories." ? I might still be misunderstanding the intent here though.
There was a problem hiding this comment.
You are right, I thought I had it "==", the idea is that a segmask can only happen if the parent dataset is one image, more than 1 image is not allowed. Updated...
There was a problem hiding this comment.
That's what I read originally so we're both losing it apparently haha. Okay good now I think!
Bugfix missing update on headers token appending.
Validator to check size match between segmentation mask and base image.