Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nickakhmetov/HMP-194 Apply fixes from lint config #3143

Merged
merged 44 commits into from
Jul 5, 2023
Merged

Nickakhmetov/HMP-194 Apply fixes from lint config #3143

merged 44 commits into from
Jul 5, 2023

Commits on Jun 27, 2023

  1. npm run lint:fix autofixes only 

    converted components to use `function`
adjusts jest tests to use `not.toBeInTheDocument` instead of `toBeNull`
removes unnecessary fragments
removes trailing spaces
    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1f2dc00 View commit details
    Browse the repository at this point in the history

  2. Fix react/no-unstable-nested-components error 

    Do not define components during render. React will see a new component type on every render and destroy the entire subtree’s DOM nodes and state (https://reactjs.org/docs/reconciliation.html#elements-of-different-types). Instead, move this component definition out of the parent component “VerticalStackedBarChart” and pass data as props.
    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    57806b6 View commit details
    Browse the repository at this point in the history

  3. allow use of require in jest tests

    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e88b8cc View commit details
    Browse the repository at this point in the history

  4. fix resolution of fonts.ts file asking for the extension

    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b9fb281 View commit details
    Browse the repository at this point in the history

  5. Fix react/jsx-no-constructed-context-values errors 

    The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook

I also turned the functions in the Files component into callbacks since they're provided in the context
    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a964374 View commit details
    Browse the repository at this point in the history

  6. Allow helpers that contain expect statements to be used as the only… 

    … expects in tests
    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    e70f38e View commit details
    Browse the repository at this point in the history

  7. add tsconfig to dockerfile

    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b6ad5ea View commit details
    Browse the repository at this point in the history

  8. Fix react/no-unstable-nested-components with DetailPanel getting … 

    …defined inside of `ProvGraph`
    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    a939c7d View commit details
    Browse the repository at this point in the history

  9. Fix undefined test global in test fixtures

    @NickAkhmetov
    NickAkhmetov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    189cf51 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Disable jsx-no-bind rule

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    6f5c2d6 View commit details
    Browse the repository at this point in the history

  2. Must use destructuring themeContext assignment (`react/destructurin… 

    …g-assignment`)
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    adb0f0b View commit details
    Browse the repository at this point in the history

  3. Default parameters should be last

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    2bf9771 View commit details
    Browse the repository at this point in the history

  4. Reorganized debounced vitessce config setter to avoid using `useCallb… 

    …ack` with unknown dependencies
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    3cdd8a4 View commit details
    Browse the repository at this point in the history

  5. Name HOC components (func-names)

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    9572b0c View commit details
    Browse the repository at this point in the history

  6. fix no-unused-vars; allow unused vars if they start with _ prefix

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d1c2280 View commit details
    Browse the repository at this point in the history

  7. use destructuring props assignment

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    72ca7f7 View commit details
    Browse the repository at this point in the history

  8. react/jsx-no-constructed-context-values 

    The object passed as the value prop to the Context provider changes every render. To fix this consider wrapping it in a useMemo hook
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4463fca View commit details
    Browse the repository at this point in the history

  9. allow empty function placeholders in test files

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    44c6a77 View commit details
    Browse the repository at this point in the history

  10. add assertions to accordion list filter tests

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0a5402a View commit details
    Browse the repository at this point in the history

  11. Avoid destructuring queries from render result, use `screen.getByTe… 

    …xt` instead
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    653b8aa View commit details
    Browse the repository at this point in the history

  12. another "screen" fix

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    630c50a View commit details
    Browse the repository at this point in the history

  13. allow "redundant" story names pending further investigation

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    7938dd4 View commit details
    Browse the repository at this point in the history

  14. reorganize to make sure components are only referenced after they're … 

    …defined, fix optional chain safety
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a50b498 View commit details
    Browse the repository at this point in the history

  15. uncomment test for the time being, will troubleshoot

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a0b57ff View commit details
    Browse the repository at this point in the history

  16. prepend unused var with _

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    f4db659 View commit details
    Browse the repository at this point in the history

  17. fix describe block name

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    36856b2 View commit details
    Browse the repository at this point in the history

  18. remove as default, make it an explicit default export

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    6424105 View commit details
    Browse the repository at this point in the history

  19. allow variables to remain unused if spreading object to remove those … 

    …keys
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    0ca12d9 View commit details
    Browse the repository at this point in the history

  20. Add explicit explanation for empty effect cleanup function

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    778bd2c View commit details
    Browse the repository at this point in the history

  21. Use getBy* queries rather than queryBy* for checking element is p… 

    …resent `testing-library/prefer-presence-queries`
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    1ec2929 View commit details
    Browse the repository at this point in the history

  22. explicitly use default export instead of as default

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    65ed652 View commit details
    Browse the repository at this point in the history

  23. use useMemo to manage SearchKitManager instance to fix useEffect … 

    …dependencies
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    989fc08 View commit details
    Browse the repository at this point in the history

  24. add swc helpers package to dev dependencies to make jest test suites … 

    …run successfully
    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4933ef1 View commit details
    Browse the repository at this point in the history

  25. Fix ProvVis test

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    2254352 View commit details
    Browse the repository at this point in the history

  26. fix accordion filter tests

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d29339f View commit details
    Browse the repository at this point in the history

  27. Add buffer polyfill to make docker image build correctly

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    a772eb2 View commit details
    Browse the repository at this point in the history

  28. Fix maintenance cypress test

    @NickAkhmetov
    NickAkhmetov committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    88497f5 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Merge branch 'nickakhmetov/hmp-194-lint-config' into nickakhmetov/hmp… 

    …-194-lint-fixes
    @NickAkhmetov
    NickAkhmetov committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    617a402 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. remove unnecessary usecallbacks

    @NickAkhmetov
    NickAkhmetov committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    fb70724 View commit details
    Browse the repository at this point in the history

  2. Update context/app/static/js/components/entity-search/SearchWrapper/u… 

    …tils.spec.js

Co-authored-by: John Conroy <[email protected]>
    @NickAkhmetov @john-conroy
    NickAkhmetov and john-conroy authored Jun 30, 2023
    Configuration menu
    Copy the full SHA
    af27648 View commit details
    Browse the repository at this point in the history

  3. Fix Jest test-utils resolution

    @NickAkhmetov
    NickAkhmetov committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    fd177b7 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary import

    @NickAkhmetov
    NickAkhmetov committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    02a4743 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Change ProvData constructor to an object

    @NickAkhmetov
    NickAkhmetov committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    639673a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'nickakhmetov/hmp-194-lint-config' into nickakhmetov/hmp… 

    …-194-lint-fixes
    @NickAkhmetov
    NickAkhmetov committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    f7f6779 View commit details
    Browse the repository at this point in the history