Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

John conroy/fix unpublished collections #3538

Merged
merged 5 commits into from
Sep 16, 2024
Merged

John conroy/fix unpublished collections #3538

merged 5 commits into from
Sep 16, 2024

Conversation

john-conroy
Copy link
Collaborator

Summary

  • Fix bug causing detail page for unpublished collections to error.
  • Drop support for collection creators.
  • Convert collection page to typescript.

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

NickAkhmetov
NickAkhmetov reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor suggestion before approving:

context/app/static/js/pages/Collection/Collection.tsx Outdated Show resolved Hide resolved
context/app/static/js/pages/Collection/Collection.tsx Outdated Show resolved Hide resolved
NickAkhmetov
NickAkhmetov approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@john-conroy john-conroy merged commit f6ae74d into main Sep 16, 2024
8 checks passed
@john-conroy john-conroy deleted the john-conroy/fix-unpublished-collections branch September 16, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickAkhmetov NickAkhmetov NickAkhmetov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-conroy @NickAkhmetov