Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

John conroy/last minute workspace updates #3543

Merged
merged 7 commits into from
Sep 18, 2024
Merged

John conroy/last minute workspace updates #3543

merged 7 commits into from
Sep 18, 2024

Conversation

john-conroy
Copy link
Collaborator

@john-conroy john-conroy commented Sep 18, 2024 •
edited
Loading

Summary

  • Increase maximum resource options for workspace jobs from 2 CPUs to 16, 32GB of memory to 128GB and session length from 6 hours to 12.
  • Add last modified date to template detail pages.

Screenshots/Video

Screenshot 2024-09-18 at 3 05 36 PM Screenshot 2024-09-18 at 3 05 20 PM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

NickAkhmetov
NickAkhmetov previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Looks good to me, one non-blocking comment/question about the tooltip text.

context/app/static/js/pages/Template/Template.tsx Outdated Show resolved Hide resolved
austenem
austenem previously approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second Nick's comment, other than that this looks good to me!

@john-conroy john-conroy merged commit 8a7fffe into main Sep 18, 2024
8 checks passed
@john-conroy john-conroy deleted the john-conroy/last-minute-workspace-updates branch September 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsliaw tsliaw tsliaw left review comments

@NickAkhmetov NickAkhmetov NickAkhmetov approved these changes

@austenem austenem austenem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-conroy @tsliaw @NickAkhmetov @austenem