Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-913 remove file accordion #3546

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

austenem
Copy link
Collaborator

Summary

Removes extra files accordion from processed datasets summary sections.

Design Documentation/Original Tickets

CAT-913 Jira ticket

Testing

Visually checked processed dataset detail pages and tested accordion functionality.

Screenshots/Video

Before fix:

Screenshot 2024-09-20 at 3 28 18 PM

After fix:

Screenshot 2024-09-20 at 3 28 12 PM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That accordion was included for publication pages' sake, but those don't appear to have files attached to them anymore (at least not the ones on prod).

In order to guard against regressions (i.e. in case a publication pops up with attached files again), could we make the inclusion of that detail section dependent on an optional prop and pass it in on the publication page side? e.g. includeAccordion

@austenem
Copy link
Collaborator Author

Ah good idea! I'll add that in.

@austenem austenem merged commit 3efd23b into main Sep 23, 2024
8 checks passed
@austenem austenem deleted the austenem/cat-913-remove-file-accordion branch September 23, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants