Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Austenem/CAT-793 unified datasets attribution #3551

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Austenem/CAT-793 unified datasets attribution #3551

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
82e31e7
switch to creation action for contact info
austenem Sep 20, 2024
5787350
add attribution section
austenem Sep 26, 2024
9ee78ff
add changelog
austenem Sep 26, 2024
167b193
add section to table of contents
austenem Sep 26, 2024
02ebae5
add creation action type
austenem Sep 26, 2024
97b91e7
check for empty contributors and add group field
austenem Sep 27, 2024
f3368c8
Update context/app/static/js/pages/Dataset/hooks.ts
austenem Oct 1, 2024
b3de042
Update context/app/static/js/components/detailPage/ProcessedData/Proc…
austenem Oct 1, 2024
c29f038
Merge branch 'main' into austenem/cat-793-unified-datasets-attribution
austenem Oct 1, 2024
7014e9e
fix parentheses issue
austenem Oct 1, 2024
c0ca82e
switch to booelean syntax
austenem Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...t/app/static/js/components/detailPage/ProcessedData/ProcessedDataset/ProcessedDataset.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ function AttributionAccordion() {
dataset: { creation_action, contributors, contacts },
} = useProcessedDatasetContext();

if (creation_action === 'Central Process' || contributors?.length === 0) {
if (creation_action === 'Central Process' || !contributors?.length) {
return null;
}

Expand Down
4 changes: 2 additions & 2 deletions context/app/static/js/pages/Dataset/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ function getProcessedDatasetSection({
const shouldDisplaySection = {
summary: true,
visualization: visualization || Boolean(conf && 'data' in conf && conf?.data),
files: Boolean(files?.length !== 0),
files: Boolean(files?.length),
analysis: Boolean(metadata?.dag_provenance_list),
attribution: creation_action !== 'Central Process' && Boolean(contributors?.length !== 0),
attribution: creation_action !== 'Central Process' && !!contributors?.length,
austenem marked this conversation as resolved.
Show resolved Hide resolved
};

const sectionsToDisplay = Object.entries(shouldDisplaySection).filter(([_k, v]) => v === true);
Expand Down
Loading