Austenem/CAT-883, CAT-914, CAT-870, CAT-868 #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAkhmetov
approved these changes
Sep 30, 2024
| @@ -41,6 +43,8 @@ export const createEntityStore = ({ springs }: { springs: ReturnType<typeof useS | |||
| summaryEntry: entry, | |||
| }, | |||
| }), | |||
| summaryHeight: 0, | |||
| setSummaryHeight: (val: number) => set({ summaryHeight: val }), | |||
There was a problem hiding this comment.
Non-blocker, just an idea:
Suggested change
| setSummaryHeight: (val: number) => set({ summaryHeight: val }), | |
| setSummaryHeight: (summaryHeight: number) => set({ summaryHeight }), |
| @@ -41,6 +43,8 @@ export const createEntityStore = ({ springs }: { springs: ReturnType<typeof useS | |||
| summaryEntry: entry, | |||
| }, | |||
| }), | |||
| summaryHeight: 0, | |||
| setSummaryHeight: (val: number) => set({ summaryHeight: val }), | |||
| view: 'narrow' as const, | |||
| setView: (val) => set({ view: val }), | |||
There was a problem hiding this comment.
Similarly, could have the arg be named "view" here 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Four minor/style bug fixes on the search, detail, and home pages.
Design Documentation/Original Tickets
CAT-868: Adjust size of "summary" view in entity headers dynamically based on the length of the content.
CAT-870: Update unified datasets link in "What’s New" section on homepage to point to an example dataset detail page.
CAT-883: Fix positioning of dropdown order menu on the tile view of the search page
CAT-914: Fix tabs moving around in bulk data transfer section on detail pages.
Testing
Manually tested all bugs, confirmed with screenshots.
Screenshots/Video
CAT-868
Issue (excess whitespace):
Fix:
CAT-870
Issue (previous redirect):
Fix (updated redirect):
CAT-883
Issue:
Fix:
CAT-914
Issue:
Screen.Recording.2024-09-30.at.10.36.02.AM.mov
Fix:
Screen.Recording.2024-09-27.at.11.09.02.AM.mov
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.