Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-934 fix metadata table #3555

Closed
wants to merge 5 commits into from

Conversation

austenem
Copy link
Collaborator

@austenem austenem commented Oct 3, 2024

Summary

Fix issue of sample metadata not showing up in the sample metadata tables.

Design Documentation/Original Tickets

CAT-934 Jira ticket

Testing

Checked metadata tables on several detail pages, including these samples that have additional sample metadata:

https://portal.hubmapconsortium.org/browse/sample/068aef7b9a77c6c61b85ad69cc8cf0d5#metadata

https://portal.hubmapconsortium.org/browse/sample/e4ee92c09a755f8889cb8c37a669e160#metadata

This issue appears to have been restricted to Sample pages (for example, this dataset detail page shows the sample metadata that is hidden on the associated Sample page).

Screenshots/Video

Issue on prod:
Screenshot 2024-10-03 at 12 01 40 PM

Fix:
Screenshot 2024-10-03 at 11 59 12 AM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

@john-conroy
Copy link
Collaborator

Let's briefly talk about this at standup before merging. We may want to differentiate sample metadata for origin, source and the current samples.

@austenem austenem closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants