Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-882 Improve entity header resize handling #3566

Merged

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR adjusts the entity header to automatically respond to screen size changes.

  • On change from large screen to small screen, the entity header is set to the narrow view.
  • On change from small screen to large screen, the entity header is restored to its previous view.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-882

Testing

Manually tested via screen resizing.

Screenshots/Video

Screen.Recording.2024-10-08.142957.mp4

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, seems like a good responsive feature for the header to have.

@NickAkhmetov NickAkhmetov merged commit 8b10e7b into main Oct 9, 2024
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-882-entity-header-responsiveness branch October 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants