Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-934 Update metadata sections #3568

Merged
merged 14 commits into from
Oct 15, 2024

Conversation

austenem
Copy link
Collaborator

Summary

This update impacts the Metadata section of the Sample, Donor, and Dataset detail pages.

  • Switches to using metadata table with tabs component from Dataset pages in the Sample and Donor pages.
  • In the metadata sections of Dataset, Sample, and Donor pages, adds tabs for any entities shown in the Provenance section with metadata. (Note: Donor pages only show the donor in the Provenance section, so all Donor metadata sections will only have a tab for the donor.)
  • Updates the metadata table component to show unique labels for each tab and to be scrollable when many tabs are present.

Design Documentation/Original Tickets

CAT-934 Jira ticket

Testing

Tested by checking several examples of each type of detail page to ensure the data in the metadata section matched that of the provenance section. If an entity from the provenance table was not included, I checked the entity's JSON to ensure it actually had no metadata.

Also tested helpers with unit tests.

Screenshots/Video

Sample example

(Local on left, prod on right)

Screenshot 2024-10-10 at 12 49 40 PM

Dataset examples

(Local on left, prod on right)

Screenshot 2024-10-10 at 12 28 55 PM

Screenshot 2024-10-10 at 12 32 36 PM

Donor example

(Local on left, prod on right)

Screenshot 2024-10-10 at 12 30 59 PM

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice job! Just a few small questions that occurred to me.

@austenem austenem merged commit 1ec62d2 into main Oct 15, 2024
8 checks passed
@austenem austenem deleted the austenem/cat-934-fix-metadata-table branch October 15, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants