Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Austenem/CAT-944 Entity header styling bugs #3569

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

austenem
Copy link
Collaborator

Summary

Fixes two WebKit/Safari-specific bugs that caused the entity header to become misaligned.

  • Bug 1: vertically misaligned view buttons in entity header, caused by their parent height being calculated differently in WebKit.
  • Bug 2: app and entity headers shifted off-screen to make room for helper panel after scrolling to a processed dataset section.

Design Documentation/Original Tickets

CAT-944 Jira ticket

Testing

Tested that both bugs were resolved in Chrome and Safari.

Screenshots/Video

Bugs on prod in Safari:
prod-ex720-2.mov
Resolved bugs locally in Safari:
safari-ex720-2.mov
Resolved bugs locally in Chrome:
chrome-ex1080.mov

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm a bit astonished that there's such a dramatic discrepancy in browser behavior. Only change in mind is switching px to rem.

…yHeaderContent/EntityHeaderContent.tsx

Co-authored-by: Nikolay Akhmetov <[email protected]>
@austenem
Copy link
Collaborator Author

Good catch! I'm a bit astonished that there's such a dramatic discrepancy in browser behavior. Only change in mind is switching px to rem.

I was as well - I wouldn't have caught it if Safari wasn't my main browser! Good call with the rem.

@austenem austenem merged commit 90f1ea4 into main Oct 11, 2024
8 checks passed
@austenem austenem deleted the austenem/cat-944-entity-header-styling-bugs branch October 11, 2024 18:05
@austenem austenem mentioned this pull request Oct 16, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants