Austenem/CAT-922 Remove QA workspace option #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAkhmetov
requested changes
Oct 11, 2024
Comment on lines
+21
to
+24
| const { mapped_data_access_level } = useDetailContext(); | ||
| const { | ||
| datasetDetails: { hubmap_id }, | ||
| } = useProcessedDatasetDetails(uuid); |
There was a problem hiding this comment.
These hooks don't work on preview and organ pages:
One potential option, similar to your feedback on my PR, would be to pull the logic for return null here up into the VisualizationWrapper and pass displayVisualizationNotebook as a prop - that would at least let us decrease the amount of prop drilling that's done solely for this functionality.
There was a problem hiding this comment.
Ah yikes! Good catch. I think that's a good idea - it looks likehasNotebook is already representing that (it's only true for the dataset detail pages), so I'll check that before trying to access the detailContext.
NickAkhmetov
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue of Workspaces button being available for protected datasets in the Visualization section.
Design Documentation/Original Tickets
CAT-922 Jira ticket
Testing
Tested protected and public datasets to ensure Workspaces button appeared only for visualizations of public + published datasets.
Screenshots/Video
Local on left, prod on right:
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.