Skip to content

fix: mixed_precision param from accelerate config should be used for FSDP mp #3864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kmehant wants to merge 1 commit into from
+1 −0
Closed

fix: mixed_precision param from accelerate config should be used for FSDP mp #3864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/accelerate/state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,6 +1005,7 @@ def __init__(
self.parallelism_config is not None and self.parallelism_config.cp_enabled
):
self.distributed_type = DistributedType.FSDP
self._mixed_precision = mixed_precision
Copy link
Member

@SunMarc SunMarc Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should already be set above, if this changed, can you check why ?

Copy link
Contributor Author

@kmehant kmehant Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked! right it was being set! Thank you.

if self._mixed_precision != "no" and fsdp_plugin is not None:
fsdp_plugin.set_mixed_precision(self._mixed_precision)
self.fsdp_plugin = fsdp_plugin
Expand Down