Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first Korean cookbook #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harheem
Copy link

@harheem harheem commented Jul 1, 2024

What does this PR do?

This PR represents the first step in adding Korean content to the Open-Source AI Cookbook. The main changes are as follows:

  1. Created 'ko' directory: A new 'ko' directory has been added under the notebooks folder to house Korean content.
  2. Added Korean Advanced RAG notebook: This notebook introduces advanced RAG (Retrieval-Augmented Generation) techniques to Korean-speaking users.
  3. Created table of contents and index files:
    • Generated the notebooks/ko/_toctree.yml file.
    • Added the notebooks/ko/index.md file.
  4. Updated workflow files: Added the 'ko' language code to build_documentation.yml and build_pr_documentation.yml files in the .github/workflows folder.

Who can review?

@jungnerd, @heuristicwave, @junejae, @nuatmochoi

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Jul 3, 2024

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-07-03T11:50:00Z
----------------------------------------------------------------

Can we find a Korean one for consistency?


Copy link

review-notebook-app bot commented Jul 3, 2024

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-07-03T11:50:00Z
----------------------------------------------------------------

no need to make numbered headings


Copy link

review-notebook-app bot commented Jul 3, 2024

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-07-03T11:50:01Z
----------------------------------------------------------------

maybe printing a few as an example would look better


Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive, gomapseumnida! 🤗
Would be great for a Korean speaking reviewer to skim through it. Left two small nits, reviewed through autotranslation in browser.

Copy link

review-notebook-app bot commented Jul 4, 2024

View / edit / reply to this conversation on ReviewNB

jungnerd commented on 2024-07-04T01:54:29Z
----------------------------------------------------------------

저장: 성된 임베딩 ...

There is a typo.

I think '저장: 완성된 임베딩 ...' is the correct sentence.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants