Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first Korean cookbook #134

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12,953 −2
Open

Add first Korean cookbook #134

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6d67a4
add first Korean cookbook
harheem Jul 1, 2024
c14da6d
update toctree
harheem Jul 3, 2024
38af351
address code review feedback
harheem Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
package_name: cookbook
path_to_docs: cookbook/notebooks/
additional_args: --not_python_module
languages: en zh-CN
languages: en zh-CN ko
convert_notebooks: true
secrets:
hf_token: ${{ secrets.HF_DOC_BUILD_PUSH }}
2 changes: 1 addition & 1 deletion .github/workflows/build_pr_documentation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:
package_name: cookbook
path_to_docs: cookbook/notebooks/
additional_args: --not_python_module
languages: en zh-CN
languages: en zh-CN ko
convert_notebooks: true
11 changes: 11 additions & 0 deletions notebooks/ko/_toctree.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
- title: 오픈소스 AI Cookbook
isExpanded: True
sections:
- local: index
title: 오픈소스 AI Cookbook

- title: LLM 레시피
isExpanded: false
sections:
- local: advanced_ko_rag
title: 한국어로 Advanced RAG 구현하기 - Hugging Face와 LangChain 활용한 Cookbook
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 한국어로 Advanced RAG 구현하기 - Hugging Face와 LangChain 활용한 Cookbook
title: 한국어로 Advanced RAG 구현하기 - Hugging Face와 LangChain을 활용한 Cookbook

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipynb 파일 제목에서도 '을' 조사를 추가하는 것과, 맨 마지막 Kiwi 부분에 대한 설명만 추가되면 좋을 것 같습니다 :)