-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Cookbook Chinese version #40
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for translating the notebooks so quickly!
The structure looks good to me, but there's one more thing to do - please add zh-CN
to the list of languages in .github/workflows/build_documentation.yml
and in .github/workflows/build_pr_documentation.yml
.
You can find an example here.
cc @stevhliu can you please check the translation? |
fine, I've already added zh-CN to the list of languages in .github/workflows/build_documentation.yml and in .github/workflows/build_pr_documentation.yml. thanks for pointing it out. @MKhalusova |
Awesome, thanks! Can you also rename the folder from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good from my side but I don't speak Chinese, so once @stevhliu checks and approves, we can merge.
Btw, if you'd like the PR review to move a bit faster, feel free to invite another Chinese-speaking community member who could review the translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Adding some suggestions regarding the translation. Feel free to update : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks for your quick update and contribution!!
Great work! Let's merge! 🔥 |
Add Cookbook Chinese version of four articles
issue #34
Hi I just translated articles into Chinese
@MKhalusova