Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Cookbook Chinese version #40

Merged
merged 10 commits into from
Feb 26, 2024
Merged

Conversation

innovation64
Copy link
Contributor

@innovation64 innovation64 commented Feb 20, 2024

Add Cookbook Chinese version of four articles

issue #34
Hi I just translated articles into Chinese

  • Automatic Embeddings with TEI through Inference Endpoints
  • Embedding multimodal data for similarity search using 🤗 transformers, 🤗 datasets and FAISS
  • Fine-tuning a Code LLM on Custom Code on a single GPU
  • Simple RAG for GitHub issues using Hugging Face Zephyr and LangChain
  • Advanced RAG on HuggingFace documentation using LangChain
  • RAG Evaluation

@MKhalusova

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@MKhalusova MKhalusova self-requested a review February 21, 2024 13:15
Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating the notebooks so quickly!
The structure looks good to me, but there's one more thing to do - please add zh-CN to the list of languages in .github/workflows/build_documentation.yml and in .github/workflows/build_pr_documentation.yml.
You can find an example here.

@MKhalusova
Copy link
Contributor

cc @stevhliu can you please check the translation?

@innovation64 innovation64 changed the title docs: Add Cookbook Chinese version of two articles docs: Add Cookbook Chinese version Feb 21, 2024
@innovation64
Copy link
Contributor Author

fine, I've already added zh-CN to the list of languages in .github/workflows/build_documentation.yml and in .github/workflows/build_pr_documentation.yml. thanks for pointing it out. @MKhalusova

@MKhalusova
Copy link
Contributor

Awesome, thanks! Can you also rename the folder from notebooks/zh to notebooks/zh-CN to match the workflows?

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good from my side but I don't speak Chinese, so once @stevhliu checks and approves, we can merge.

@MKhalusova
Copy link
Contributor

Btw, if you'd like the PR review to move a bit faster, feel free to invite another Chinese-speaking community member who could review the translation.

Copy link

@adeenayakup adeenayakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Adding some suggestions regarding the translation. Feel free to update : )

notebooks/zh-CN/_toctree.yml Outdated Show resolved Hide resolved
notebooks/zh/rag_zephyr_langchain.ipynb Outdated Show resolved Hide resolved
notebooks/zh/index.md Outdated Show resolved Hide resolved
notebooks/zh/index.md Outdated Show resolved Hide resolved
notebooks/zh/index.md Outdated Show resolved Hide resolved
notebooks/zh/index.md Outdated Show resolved Hide resolved
notebooks/zh/index.md Outdated Show resolved Hide resolved
Copy link

@adeenayakup adeenayakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for your quick update and contribution!!

@MKhalusova
Copy link
Contributor

Great work! Let's merge! 🔥

@MKhalusova MKhalusova merged commit 159fe6f into huggingface:main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants