Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line wrapping in Select component #691

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: line wrapping in Select component #691

merged 1 commit into from
Jan 24, 2024

Conversation

Scooter1337
Copy link
Contributor

@Scooter1337 Scooter1337 commented Jan 24, 2024

Closes #689

Makes Select components more consistent with the original ShadCn repo, by disabling line wrapping in select trigger.

Before:
Screenshot

After:
Screenshot

Compare https://www.shadcn-svelte.com/themes (width set to 1280px)

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 2:56am

Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: 8a35733

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Scooter1337 Scooter1337 marked this pull request as ready for review January 24, 2024 02:52
@Scooter1337 Scooter1337 changed the title fix: Select components not wrapping fix: line wrapping in Select component Jan 24, 2024
Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit 811a062 into huntabyte:main Jan 24, 2024
4 checks passed
@Scooter1337 Scooter1337 mentioned this pull request Jan 27, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small inconsistency
2 participants