This repository was archived by the owner on Feb 29, 2024. It is now read-only.
Merged
Conversation
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
jovfer
approved these changes
Jun 23, 2021
Patrik-Stas
approved these changes
Jun 23, 2021
Patrik-Stas
suggested changes
Jun 23, 2021
Contributor
Patrik-Stas
left a comment
Patrik-Stas
left a comment
There was a problem hiding this comment.
Small changes requested
Patrik-Stas
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of
rusqlite(0.20.0) is transitively dependent onlinked-hash-map v0.5.3, which contains a bug (fixed in version0.5.4). This bug causes runtime panics due to uninitialized reference on wallet access since rust1.48.0. See here, here, and here.This PR updates version of rusqlite which fixes the bug (replicating the changes in #2311 with green DCO), as the latest version of rusqlite removes dependency on
linked-hash-map.Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com