Skip to content

ci: install irohad with features #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

ci: install irohad with features #5354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/iroha2-dev-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,16 @@ jobs:
run: |
mv ${{ env.WASM_TARGET_DIR }}/libs ${{ env.DEFAULTS_DIR }}/libs
mv ${{ env.DEFAULTS_DIR }}/libs/default_executor.wasm ${{ env.DEFAULTS_DIR }}/executor.wasm
- name: Install irohad
run: which irohad || cargo install --path crates/irohad --locked
Copy link
Contributor Author

@s8sato s8sato Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, what is the possible cases that irohad is found by which command here @0x009922 ?

Copy link
Contributor

@0x009922 0x009922 May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, it was about caching and the possibility that irohad is already available. Though I don't understand how that could be possible.

- name: Install irohad with no default features
run: cargo install --path crates/irohad --locked --no-default-features
- name: Test with no default features
id: test_no_features
run: >
mold --run cargo llvm-cov nextest
--no-default-features
--branch --no-report
- name: Install irohad with all features
run: cargo install --path crates/irohad --locked --all-features
- name: Test with all features
id: test_all_features
run: >
Expand Down
Loading