Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] upgrade web3j plugins #8296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[build] upgrade web3j plugins #8296

wants to merge 2 commits into from

Conversation

macfarla
Copy link
Contributor

PR description

Related to #8295 - upgrade web3j plugin resolves more gradle deprecation warnings

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
upgrade web3j plugins
4febec0 
Signed-off-by: Sally MacFarlane <[email protected]>
siladu
siladu reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to go to 4.12.3?

acceptance-tests/tests/build.gradle
@@ -12,8 +12,8 @@
*/

plugins {
id 'org.web3j' version '4.11.3'
id 'org.web3j.solidity' version '0.4.1'
id 'org.web3j' version '4.12.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id 'org.web3j' version '4.12.2'
id 'org.web3j' version '4.12.3'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the gradle checkLicense task fails - I've asked the q in Besu discord https://discord.com/channels/905194001349627914/905205502940696607/1339482205839298612

acceptance-tests/tests/shanghai/build.gradle
@@ -1,7 +1,7 @@

plugins {
id 'org.web3j' version '4.11.3'
id 'org.web3j.solidity' version '0.4.1'
id 'org.web3j' version '4.12.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id 'org.web3j' version '4.12.2'
id 'org.web3j' version '4.12.3'

siladu
siladu approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw your message about 4.12.3 in discord

@macfarla
Copy link
Contributor Author

saw your message about 4.12.3 in discord

also put link here for visibility

@macfarla macfarla mentioned this pull request Feb 13, 2025
Open
9 tasks
@macfarla macfarla added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Feb 13, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@macfarla macfarla added this pull request to the merge queue Feb 14, 2025
@macfarla macfarla enabled auto-merge (squash) February 14, 2025 02:16
@macfarla
Copy link
Contributor Author

AT job failed after 35 min https://github.com/hyperledger/besu/actions/runs/13321106889/job/37205785037?pr=8296

The message received from the daemon indicates that the daemon has disappeared.
Build request sent: Build{id=6baafe87-13d5-43b2-b161-b4896ca6b862, currentDir=/home/runner/work/besu/besu}
Attempting to read last messages from the daemon log...
Daemon pid: 1942
  log file: /home/runner/.gradle/daemon/8.8/daemon-1942.out.log
----- Last  20 lines from daemon log file - daemon-1942.out.log -----
2025-02-14T02:20:43.460+0000 [DEBUG] [org.gradle.launcher.daemon.server.DefaultDaemonConnection] thread [204](https://github.com/hyperledger/besu/actions/runs/13321106889/job/37205785037?pr=8296#step:14:205): Received non-IO message from client: Build{id=6baafe87-13d5-43b2-b161-b4896ca6b862, currentDir=/home/runner/work/besu/besu}
2025-02-14T02:20:43.460+0000 [INFO] [org.gradle.launcher.daemon.server.DefaultIncomingConnectionHandler] Received command: Build{id=6baafe87-13d5-43b2-b161-b4896ca6b862, currentDir=/home/runner/work/besu/besu}.
2025-02-14T02:20:43.461+0000 [DEBUG] [org.gradle.launcher.daemon.server.DefaultIncomingConnectionHandler] Starting executing command: Build{id=6baafe87-13d5-43b2-b161-b4896ca6b862, currentDir=/home/runner/work/besu/besu} with connection: socket connection from /127.0.0.1:38603 to /127.0.0.1:48736.
2025-02-14T02:20:43.461+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] Command execution: started DaemonCommandExecution[command = Build{id=6baafe87-13d5-43b2-b161-b4896ca6b862, currentDir=/home/runner/work/besu/besu}, connection = DefaultDaemonConnection: socket connection from /127.0.0.1:38603 to /127.0.0.1:48736] after 0.0 minutes of idle
2025-02-14T02:20:43.461+0000 [INFO] [org.gradle.launcher.daemon.server.DaemonRegistryUpdater] Marking the daemon as busy, address: [dfab7cdc-9d39-4e23-84d9-8aea16957124 port:38603, addresses:[localhost/127.0.0.1]]
2025-02-14T02:20:43.461+0000 [DEBUG] [org.gradle.launcher.daemon.registry.PersistentDaemonRegistry] Marking busy by address: [dfab7cdc-9d39-4e23-84d9-8aea16957124 port:38603, addresses:[localhost/127.0.0.1]]
2025-02-14T02:20:43.461+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Waiting to acquire exclusive lock on daemon addresses registry.
2025-02-14T02:20:43.462+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
2025-02-14T02:20:43.462+0000 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Releasing lock on daemon addresses registry.
2025-02-14T02:20:43.462+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] resetting idle timer
2025-02-14T02:20:43.462+0000 [DEBUG] [org.gradle.launcher.daemon.server.DaemonStateCoordinator] daemon is running. Sleeping until state changes.
2025-02-14T02:20:43.462+0000 [INFO] [org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy] Daemon is about to start building Build{id=6baafe87-13d5-43b2-b161-b4896ca6b862, currentDir=/home/runner/work/besu/besu}. Dispatching build started information...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @siladu