fix(abr): allow empty string not null (#3)

hyraiq · Apr 20, 2023 · 4f4ca91 · 4f4ca91
1 parent 5753351
commit 4f4ca91
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Model/AbnResponse.php b/src/Model/AbnResponse.php
@@ -30,10 +30,10 @@ final class AbnResponse extends AbstractResponse
     public \DateTimeImmutable $addressDate;
 
     #[SerializedName('AddressPostcode')]
-    public ?string $addressPostcode;
+    public string $addressPostcode;
 
     #[SerializedName('AddressState')]
-    public ?string $addressState;
+    public string $addressState;
 
     /**
      * @var string[]

diff --git a/tests/Model/AbnResponseTest.php b/tests/Model/AbnResponseTest.php
@@ -49,12 +49,12 @@ public function getValidTests(): \Generator
         yield 'no gst' => [$fields];
 
         $fields                 = MockAbnResponse::valid();
-        $fields['AddressState'] = null;
-        yield 'no address state' => [$fields];
+        $fields['AddressState'] = '';
+        yield 'empty string for address state' => [$fields];
 
         $fields                    = MockAbnResponse::valid();
-        $fields['AddressPostcode'] = null;
-        yield 'no AddressPostcode' => [$fields];
+        $fields['AddressPostcode'] = '';
+        yield 'empty string for address postcode' => [$fields];
     }
 
     /**