Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(null): handle nullable postcode and state ZNA #2

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix(null): handle nullable postcode and state ZNA #2

merged 2 commits into from
Apr 20, 2023

Conversation

tomtomau
Copy link
Contributor

Some record in the ABR, particularly New Zealand entities (in Australia?!) appear to not have a postcode/state, so this PR makes them nullable.

This will need a BC break

@tomtomau tomtomau requested a review from ndench April 20, 2023 06:58
@tomtomau tomtomau merged commit 5753351 into main Apr 20, 2023
@tomtomau tomtomau deleted the fix/nullable-address-state branch April 20, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndench ndench ndench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomtomau @ndench