Skip to content

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented Jul 28, 2025

PR Type

Bug fix


Description

This description is generated by an AI tool. It may have inaccuracies

  • Fixed barometer I2C address configuration for DPS310

  • Corrected ICM42605 chip select pin assignment

  • Removed unused SPI NSS pin definitions

  • Cleaned up commented configuration lines


Diagram Walkthrough

flowchart LR
  A["Target Config Issues"] --> B["Fix Baro I2C Address"]
  A --> C["Fix ICM42605 CS Pin"]
  A --> D["Remove Unused SPI NSS"]
  A --> E["Clean Comments"]
Loading

File Walkthrough

Relevant files
Bug fix
target.h
Fix DPS310 barometer I2C address                                                 

src/main/target/BRAHMA_F405/target.h

  • Changed BARO_I2C_ADDR to DPS310_I2C_ADDR for proper DPS310 barometer
    configuration
+1/-1     
target.h
Fix multiple hardware pin configurations                                 

src/main/target/BRAHMA_F722/target.h

  • Changed BARO_I2C_ADDR to DPS310_I2C_ADDR for DPS310 barometer
  • Fixed ICM42605_CS_PIN from SPI1_NSS_PIN to PC13
  • Removed unused SPI1_NSS_PIN, SPI2_NSS_PIN, SPI3_NSS_PIN definitions
  • Cleaned up commented temperature, pitot, and rangefinder bus
    configurations
+2/-10   

@DzikuVx DzikuVx added this to the 8.1 milestone Jul 28, 2025
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
⚡ Recommended focus areas for review

Pin Conflict

The ICM42605_CS_PIN is set to PC13, which is the same pin used for LED0. This could cause hardware conflicts between the IMU chip select and LED functionality.

#define ICM42605_CS_PIN         PC13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant