Conversation
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
Contributor
Review Summary by QodoAdd comprehensive AGENT.md guide for AI developers
WalkthroughsDescription• Comprehensive AI agent guide for INAV flight controller firmware • Covers architecture, coding conventions, build system, and key concepts • Includes development workflow, common patterns, and important guidelines • Provides quick reference and resources for contributors Diagramflowchart LR
A["INAV Project Overview"] --> B["Architecture & Structure"]
B --> C["Coding Conventions"]
C --> D["Build System"]
D --> E["Key Concepts"]
E --> F["Development Workflow"]
F --> G["AI Agent Guidelines"]
G --> H["Quick Reference"]
File Changes1. AGENT.md
|
Contributor
Code Review by Qodo
1. SLOW_RAM mislabeled deprecated
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+86
to
+92
| ```c | ||
| FASTRAM // Fast RAM section (aligned) | ||
| EXTENDED_FASTRAM // Extended fast RAM (STM32F4/F7 only) | ||
| DMA_RAM // DMA-accessible RAM (STM32H7, AT32F43x) | ||
| SLOW_RAM // Slower external RAM - deprecated, o not use | ||
| STATIC_FASTRAM // Static variable in fast RAM | ||
| STATIC_FASTRAM_UNIT_TESTED // Static fast RAM variable visible in unit tests |
Contributor
There was a problem hiding this comment.
1. Slow_ram mislabeled deprecated 🐞 Bug ✓ Correctness
AGENT.md states SLOW_RAM is deprecated (“do not use”), but the codebase still defines and uses it, which may prompt agents to remove/avoid it and break memory placement on affected MCUs.
Agent Prompt
## Issue description
AGENT.md incorrectly marks `SLOW_RAM` as deprecated even though it is still defined and used in production code. This can mislead agents into removing or avoiding `SLOW_RAM` usage, potentially breaking memory placement.
## Issue Context
`SLOW_RAM` is defined in `src/main/build/build_config.h` and is used (e.g., for EEPROM buffering) in `src/main/config/config_streamer.c`.
## Fix Focus Areas
- AGENT.md[86-92]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's help agents a little