Use explicit PWM timers first#11444
Closed
sensei-hacker wants to merge 11 commits intoiNavFlight:maintenance-9.xfrom
Closed
Use explicit PWM timers first#11444sensei-hacker wants to merge 11 commits intoiNavFlight:maintenance-9.xfrom
sensei-hacker wants to merge 11 commits intoiNavFlight:maintenance-9.xfrom
Conversation
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
4 tasks
sensei-hacker
force-pushed
the
pwm_use_explicit_timers_first
branch
10 times, most recently
from
77cb935 to
dda0932
Compare
Create per-pin AF lookup tables (bus_spi_stm32h7xx.h and bus_spi_stm32f7xx.h) and use them in bus_spi_hal_ll.c to automatically resolve the correct GPIO AF for each SPI pin. Previously, SPI3 on STM32H743 applied AF6 to all pins. On H743, AF6 on PB5 is SPI3_MISO - the MOSI function requires AF7. Targets routing SPI3_MOSI to PB5 (e.g. HAKRCH743 MAX7456 OSD) received no MOSI signal. Targets may still define SPI*_SCK/MISO/MOSI_AF in target.h to override the table.
Both bus_spi_stm32h7xx.h and bus_spi_stm32f7xx.h use CONCAT4 but relied on transitive includes from the including translation unit to provide it. Add an explicit include to make the dependency self-contained.
Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com>
Deprecate the following MSP commands with replacement info: - MSP_ANALOG (110) -> MSP2_INAV_ANALOG - MSP_MISC (114) / MSP_SET_MISC (207) -> MSP2_INAV_MISC / MSP2_INAV_SET_MISC - MSP_PIDNAMES (117) -> no replacement needed - MSP_FILTER_CONFIG (92) / MSP_SET_FILTER_CONFIG (93) -> MSP2_COMMON_SETTING - MSP_PID_ADVANCED (94) / MSP_SET_PID_ADVANCED (95) -> MSP_INAV_PID - MSP_OSD_CONFIG (84) / MSP_SET_OSD_CONFIG (85) -> MSP2_INAV_OSD_* - MSP_POSITION_ESTIMATION_CONFIG (16) / MSP_SET_POSITION_ESTIMATION_CONFIG (17) -> MSP2_COMMON_SETTING - MSP_SERVO_MIX_RULES (241) / MSP_SET_SERVO_MIX_RULE (242) -> MSP2_INAV_SERVO_MIXER Commands remain fully functional. This gives third-party developers a full major release cycle of notice before removal. Also adds "replaced_by" field to the MSP message JSON schema (docs/development/msp/format.md) and populates it for all 14 entries.
Co-authored-by: qodo-code-review[bot] <151058649+qodo-code-review[bot]@users.noreply.github.com>
Add replaced_by fields to msp_messages.json and deprecation comments to msp_protocol.h for MSP_BLACKBOX_CONFIG, MSP_SET_BLACKBOX_CONFIG, MSP_STATUS, and MSP_DEBUG. MSP_STATUS_EX not marked deprecated because its accCalibAxisFlags field is absent from MSP2_INAV_STATUS.
…N_DATA MSP2_INAV_STATUS supersedes MSP_STATUS_EX for all status fields. The accCalibAxisFlags field absent from MSP2_INAV_STATUS is available via MSP_CALIBRATION_DATA.
sensei-hacker
force-pushed
the
pwm_use_explicit_timers_first
branch
from
dda0932 to
e09cbc3
Compare
|
Test firmware build ready — commit Download firmware for PR #11444 227 targets built. Find your board's
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, even if the user specifically set MOTOR and SERVO timers (output), it would instead use the AUTO ones, disregarding the user's explicit instructions:
Now, it follows instructions - if the user sets a timer as servos, use that for servos first:
Goes with Configurator PR:
iNavFlight/inav-configurator#2596