Updated Crossfire telemetry FM strings for 3.0

[MrD-RC]

Changed the old 3CRS to CRUZ and CRS to CRSH, to reflect the mode changes.

[OptimusTi]

Will this change break functionality with LUATelemetry?

[MrD-RC]

@OptimusTi I did realise that after posting. But figured to leave it up, and maybe I’ll look at the LUA.

[wx4cb]

@OptimusTi I did realise that after posting. But figured to leave it up, and maybe I’ll look at the LUA.

you theoretically wouldn't need to change anything as OTTOMH i think it goes by the modes numeric value.

[OptimusTi]

OTTOMH

The lua script (and possibly OpenTX) expects a string from crsf telemetry. Not a number. right?

[wx4cb]

OTTOMH

The lua script (and possibly OpenTX) expects a string from crsf telemetry. Not a number. right?

i am not sure. not by my pc to double check. but it might just be in modes.lua that you need to deal with.

[MrD-RC]

I’ve had a quick look, and it looks like https://github.com/iNavFlight/OpenTX-Telemetry-Widget/blob/master/src/SCRIPTS/TELEMETRY/iNav/crsf.lua would need to be changed, but I believe that would be all.

Of course, the LUA script it’s self could be updated to use the terms Course Hold and Cruise.

[wx4cb]

@MrD-RC That would be correct, but i would assume that would be for crossfire only and not all radios. there was an issue before where one sensor was called something different in crossfire than other radios but i could also be thinking about something else too :D

[OptimusTi]

Check OpenTX too. :) Not familiar with the code and I can't find anything... but FM is in the sensors. It may spit out whatever it's sent though...(looks like that's the case so OTX may not be affected)

[MrD-RC]

I had a look in EdgeTX and could only see FLIGHT_MODE_ID. I'm sure it just displays the string it receives.

[MrD-RC]

I've updated the LUA. It will still work with older versions too. iNavFlight/OpenTX-Telemetry-Widget#4

[MrD-RC]

... and here teckel12/LuaTelemetry#467

[DzikuVx]

@MrD-RC Should we merge or not so much?

[MrD-RC]

@DzikuVx The change has been added as a PR to both LUA scripts, and merged in the iNav repo version. It would kind of make sense to merge it now, rather than later, as we are already breaking backwards compatibility with this master. Up to you though mate. It would make sense to change, as the modes are now different.

[DzikuVx]

Then let's merge it as our fork works just fine. Thanks

[stronnag]

@mr-rc please add LUA changes to the official inav LUA widget repo

[MrD-RC]

@mr-rc please add LUA changes to the official inav LUA widget repo

Already merged ;) iNavFlight/OpenTX-Telemetry-Widget#4

[stronnag]

@mr-rc please add LUA changes to the official inav LUA widget repo

Already merged ;) iNavFlight/OpenTX-Telemetry-Widget#4

Thanks. I should have known that.