Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split itinerary checks into threads #313

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

br648
Copy link
Contributor

@br648 br648 commented Feb 26, 2025

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This PR attempts to address the bottleneck with making OTP requests for checking itineraries by replacing the existing process with multi-threading.

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse OTP_SERVER_REQUEST_TIMEOUT_IN_SECONDS from OtpDispatcher and make that configurable?

@br648 br648 assigned binh-dam-ibigroup and unassigned br648 Mar 6, 2025
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significantly better response saving trips on complicated graphs! Just one nit in the example YML file.

@br648 br648 assigned JymDyerIBI and unassigned br648 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants