-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split itinerary checks into threads #313
base: dev
Are you sure you want to change the base?
Conversation
…return otp response based on da
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse OTP_SERVER_REQUEST_TIMEOUT_IN_SECONDS
from OtpDispatcher
and make that configurable?
src/main/java/org/opentripplanner/middleware/models/ItineraryExistence.java
Show resolved
Hide resolved
src/test/java/org/opentripplanner/middleware/utils/ItineraryUtilsTest.java
Show resolved
Hide resolved
src/test/java/org/opentripplanner/middleware/utils/MockOtpResponseProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Significantly better response saving trips on complicated graphs! Just one nit in the example YML file.
Checklist
dev
before they can be merged tomaster
)Description
This PR attempts to address the bottleneck with making OTP requests for checking itineraries by replacing the existing process with multi-threading.