Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simmechanics configuration of the hands #115

Merged
merged 3 commits into from
May 23, 2023

Conversation

xEnVrE
Copy link
Contributor

@xEnVrE xEnVrE commented May 17, 2023

Within this PR:

  • joints limits of hand joints aligned with CAD;

please note that these will vary from those that can be found in robotology/robots-configuration as the finger configurations on the real robot is not completed yet.

these values have been obtained by asking to those working on the CAD of the hands.

at the moment there is an open issue for documenting such limits, see https://github.com/icub-tech-iit/ergocub-design-lowerarm/issues/132.

  • Gazebo configuration files updated in order to :
    • specify limits of coupled joints
    • use the integrator_and_position_pid mode for the YARP velocity control (as on the real robot as far as I know)
    • provide a working, although non-optimized, PID configuration for the direct_velocity_pid mode for YARP velocity control

cc @mfussi66 @Nicogene @traversaro @pattacini

@xEnVrE
Copy link
Contributor Author

xEnVrE commented May 17, 2023

This PR is tightly coupled with robotology/gazebo-yarp-plugins#650.

@xEnVrE
Copy link
Contributor Author

xEnVrE commented May 23, 2023

robotology/gazebo-yarp-plugins#650 has been merged.

We would also need to merge this PR in order to make sure that the hand is properly simulated, as the configuration files are hosted here.

cc @traversaro @Nicogene

@traversaro traversaro requested a review from Nicogene May 23, 2023 07:20
@traversaro
Copy link
Member

robotology/gazebo-yarp-plugins#650 has been merged.

We would also need to merge this PR in order to make sure that the hand is properly simulated, as the configuration files are hosted here.

cc @traversaro @Nicogene

My bad, I did not tought of coordinating on the merge time. @Nicogene do you have any idea on this PR?

@Nicogene Nicogene merged commit 6d9950b into icub-tech-iit:master May 23, 2023
1 check passed
@Nicogene
Copy link
Member

I would tag gazebo-yarp-plugins in order to make the dependency explicit in the README of this repo

cc @xEnVrE @traversaro

@traversaro
Copy link
Member

I would tag gazebo-yarp-plugins in order to make the dependency explicit in the README of this repo

cc @xEnVrE @traversaro

Ok, prepared in robotology/gazebo-yarp-plugins#652 . However I would prefer to actually tag the release if we do soon also a release of ergocub-software, otherwise the latest releases configuration of the superbuild would be broken. Do you think we can do a release of ergocub-software now or there is something blocking (probably the related changes in robots-configurations ? ).

@traversaro
Copy link
Member

I would tag gazebo-yarp-plugins in order to make the dependency explicit in the README of this repo
cc @xEnVrE @traversaro

Ok, prepared in robotology/gazebo-yarp-plugins#652 . However I would prefer to actually tag the release if we do soon also a release of ergocub-software, otherwise the latest releases configuration of the superbuild would be broken. Do you think we can do a release of ergocub-software now or there is something blocking (probably the related changes in robots-configurations ? ).

@xEnVrE @Nicogene I guess now we can proceed to tag both gazebo-yarp-plugins and ergocub-software ?

@Nicogene
Copy link
Member

Nicogene commented Jun 5, 2023

@xEnVrE @Nicogene I guess now we can proceed to tag both gazebo-yarp-plugins and ergocub-software ?

Yes! First GYP right?

@traversaro
Copy link
Member

Done: https://github.com/robotology/gazebo-yarp-plugins/releases/tag/v4.7.0 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants