Fix trailing null bytes in JSON output and add C-string termination #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixw4
approved these changes
Oct 29, 2025
…rors Add PROVER_ERROR_INSUFFICIENT_BUFFER to distinguish between buffer size failures that occur before vs after proof generation: - PROVER_ERROR_SHORT_BUFFER: Buffer smaller than minimum size, checked before calling the expensive prove() operation. Allows early return without wasting computation. - PROVER_ERROR_INSUFFICIENT_BUFFER: Buffer smaller than actual proof output size, checked after prove() completes. Occurs when proof size exceeds the minimum estimate. This two-phase validation prevents unnecessary proof generation when buffers are obviously too small, while handling edge cases where the actual proof exceeds minimum size estimates. Additional improvements: - Add CopyErrorFmt() for safe variadic error formatting - Fix error messages to show original (not updated) buffer sizes - Add overflow protection for buffer size calculations - Replace strncpy with memcpy for explicit string handling - Remove unused ShortBufferException and CheckAndUpdateBufferSizes - Document buffer size semantics (output excludes null terminator) - Fix CopyError to guarantee null-termination with snprintf
nixw4
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.