Skip to content

Fix trailing null bytes in JSON output and add C-string termination #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix trailing null bytes in JSON output and add C-string termination #36

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4d1dd5
src/prover.cpp
olomix Oct 16, 2025
ec89fef
Add fallback mirrors for GMP download
olomix Oct 30, 2025
ff40d99
Refactor buffer validation with separate pre/post proof generation er…
olomix Oct 31, 2025
5f299c0
missing header
olomix Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/prover.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,15 +360,21 @@ groth16_prover_prove(

prover->prove(wtns_buffer, wtns_size, stringProof, stringPublic);

CheckAndUpdateBufferSizes(stringProof.length(), proof_size,
stringPublic.length(), public_size,
unsigned long long original_proof_size = *proof_size;
unsigned long long original_public_size = *public_size;

CheckAndUpdateBufferSizes(stringProof.length() + 1, proof_size,
stringPublic.length() + 1, public_size,
"Required");

*proof_size = stringProof.length();
*public_size = stringPublic.length();

std::strncpy(proof_buffer, stringProof.c_str(), *proof_size);
proof_buffer[*proof_size] = '\0';

std::strncpy(public_buffer, stringPublic.c_str(), *public_size);
public_buffer[*public_size] = '\0';

} catch(InvalidWitnessLengthException& e) {
CopyError(error_msg, error_msg_maxsize, e);
Expand Down
Loading