created "on-insert" custom modifier; updated LocaleChooser #7919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if this was the intended "fix" for this problem, but I learned a bit, regardless. |
|
superseded by #7922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374
In order to fix the deprecated
{{did-insert}}modifier, I created an{{on-insert}}custom modifier that just takes a callback, runs if valid, or performs aconsole.errorif not.I tested this on the
<LocaleChooser>component, and it seems to work as expected. Can probably reuse this in other spots where we are doing a simple "did this thing load? if so, do this other thing" check.