replace {{did-insert}} modifiers in LocaleChooser component #7922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
locale-chooser
branch
from
5032467
to
e0c7d51
Compare
|
I nominate your alternative solution after our discussion. |
|
Oh this is nice, I was originally thinking we'd have to go with @michaelchadwick's solution in a bunch of places where we use |
sometimes, the given element is all we need.
…at element. we have full control over this component's markup, so let's traverse it to markup from the click target to the toggle button, instead of tracking the toggle button separately. one less modifier.
drop-in replacement.
stopfstedt
force-pushed
the
locale-chooser
branch
from
e0c7d51
to
223e545
Compare
jrjohnson
requested changes
Jul 5, 2024
| @@ -98,3 +98,5 @@ add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c0 | |||
| add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1719360000000|1734915600000|1750464000000|app/components/reports/subject/new/session-type.hbs | |||
| add|ember-template-lint|no-at-ember-render-modifiers|10|6|10|6|d919d2af254f782c01fe2ba15416673e52e91124|1719360000000|1734915600000|1750464000000|app/components/reports/subject/new/term.hbs | |||
| add|ember-template-lint|no-at-ember-render-modifiers|11|6|11|6|940005188b476a060b0e5d3f05baea24ba178878|1719360000000|1734915600000|1750464000000|app/components/reports/subject/new/term.hbs | |||
| remove|ember-template-lint|no-at-ember-render-modifiers|16|4|16|4|46d995f60904f6b6f4b1b6b24bb65b9c97441bc1|1719360000000|1734915600000|1750464000000|app/components/locale-chooser.hbs | |||
There was a problem hiding this comment.
If you run pnpm run lint:hbs --compact-todo it will clean this up. Otherwise I think it creates a double entry instead of removing the original.
| await component.locales[1].click(); | ||
| assert.strictEqual(component.locales.length, 0); | ||
| assert.strictEqual(component.text, 'Español (es)'); | ||
| assert.ok(component.toggle.hasFocus); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ilios/ilios#5374
an alternative solution to #7919