Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace {{did-insert}} modifiers in LocaleChooser component #7922

Merged
merged 6 commits into from
Jul 8, 2024
Merged

replace {{did-insert}} modifiers in LocaleChooser component #7922

merged 6 commits into from
Jul 8, 2024

Commits on Jul 8, 2024

  1. focus on locale picker toggle button on locale change without trackin… 

    …g that element.
    @stopfstedt
    stopfstedt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a470604 View commit details
    Browse the repository at this point in the history

  2. make selector input optional on has-focus helper. 

    sometimes, the given element is all we need.
    @stopfstedt
    stopfstedt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d57d969 View commit details
    Browse the repository at this point in the history

  3. focus the toggle button on locale-change without the need to track th… 

    …at element.

we have full control over this component's markup, so let's traverse it
to markup from the click target to the toggle button,
instead of tracking the toggle button separately.
one less modifier.
    @stopfstedt
    stopfstedt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5ee8c97 View commit details
    Browse the repository at this point in the history

  4. replace did-insert modifier with focus modifier. 

    drop-in replacement.
    @stopfstedt
    stopfstedt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c7220ff View commit details
    Browse the repository at this point in the history

  5. replace {{autofocus}} modifier with {{focus}}. rm obsolete autofocus.

    @stopfstedt
    stopfstedt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5190cdc View commit details
    Browse the repository at this point in the history

  6. rm obsolete todos.

    @stopfstedt
    stopfstedt committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    396a0f1 View commit details
    Browse the repository at this point in the history